19f05857
ci: drop the 'all' from go mod download, which rewrote go.sum
The cache warm-up was 'go mod download all'. That resolves the entire module graph, test dependencies of dependencies included, and appends their hashes to go.sum — 145 lines in this repository, measured in a fresh clone of this branch. Which makes it the bug this wave exists to remove. A modified tracked file in the checkout when go build runs is what stamps vcs.modified into the binary, the same failure the version task avoids by not sed-ing the APKBUILD; the warm-up would have reintroduced it one task later. The bench sibling proved it first: build #359 stopped at check-version with a -dirty binary and 'M go.sum' named as the thing in the way, 228 lines there. Without 'all' go.sum is untouched, go mod verify still passes, and what is fetched is what the main module builds, which is all a warm-up needs. Also removes the sentence that let this through. Both the manifest and docs/ci.md claimed -mod=readonly is the default so neither command can rewrite go.mod or go.sum. It is false, and it sat directly above the line that disproved it. readonly governs updates to the module requirements, not writes to go.sum: measured here with the flag set explicitly on the command line, 'go mod download all' still appends the same 145 lines and still exits 0, and go mod verify passes after it, so verification guards nothing either. Setting the flag on the command line is the point. This machine carries go env -w GOFLAGS=-mod=mod, as bench's did, so a run that omits it proves nothing about the builder. What remains is the git status --porcelain at the end of the task, and it is now documented as the check rather than as belt-and-braces: it is the only thing that would notice a go.sum rewrite before the compile, and on bench it is what did. docs/ci.md warns against restoring the 'all' and against replacing the print with an appeal to a flag. compare's README makes no claim about module hygiene in CI, so nothing to correct there
bigbes <bigbes@gmail.com> — 2026-08-08 22:32:26 UTC
Commit 19f0585714695aa711b0a70e601ded7770118bd6 —
view raw patch
Parent(s):
f8283861
| File | Status | + | − |
|---|---|---|---|
.build.yml
|
M | +17 | -5 |
docs/ci.md
|
M | +59 | -6 |